Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OHHTTPStubs] Resolved circular dependency when using dynamic framework #128

Closed
wants to merge 1 commit into from

Conversation

aaresu
Copy link

@aaresu aaresu commented Oct 12, 2015

Moved import of OHHTTPStubsResponse from .h to .m to resolving circular dependencies when using dynamic framework.

@AliSoftware
Copy link
Owner

Currently OHHTTPStubs.h is the umbrella header for the framework, so OHHTTPStubs.h is required by Xcode to import all the headers of the framework.

There is an issue about that (#127) and I need to find a way to solve it, probably by specifying a custom umbrella header in the Build Settings instead than the default one (which is the .h file having the same name as the framework, hence OHHTTPStubs.h here) and configure it right for all use cases:

  • When OHHTTPStubs is used as a static lib
  • When OHHTTPStubs is used as a a framework installed manually
  • When OHHTTPStubs is used as a a framework via Carthage
  • When OHHTTPStubs is used as a a framework via CocoaPods
  • When OHHTTPStubs is used as a a framework via CocoaPods and the user only choose to pick some of the pod's subspecs and not all

@AliSoftware
Copy link
Owner

I'm closing this as this fix continue to break for other configurations, esp. frameworks integrated via Carthage vs. CocoaPods vs. Rome vs. manual etc.

I started a branch fix/umbrella-header to try and fix it using a more generic approach.

Thx for the effort and the PR though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants